search

funkyg / funkytunes

A streaming music player for Android, using torrents.
GNU General Public License v3.0
122 stars 24 forks source link

Double clicking a song title hangs the player #30

Open gjedeer opened 7 years ago

gjedeer commented 7 years ago

Tested with master and show-loading-notification branches, happens in both.

Reproducing:

Music stops playing and MusicService thinks it's still playing. Logcat:

06-06 22:11:16.376 26763 26763 I MusicService: Playing track 01 - Eraser.mp3
06-06 22:11:16.493 26763 26763 I MusicService: Playing track 02 - Castle on the Hill.mp3
06-06 22:11:16.664 26763 26763 I MusicService: Playing track 03 - Dive.mp3
06-06 22:11:44.157 26763 26792 I MusicService: Playing track 06 - Galway Girl.mp3
06-06 22:12:09.168 26763 26792 I MusicService: Playing track 08 - New Man.mp3
funkyg commented 7 years ago

hmm that works fine for me (tested with 0.1.3 release). it might be some kind of race condition?

gjedeer commented 7 years ago

This happened pretty often to me, interesting that you could not reproduce it. I will try coming up with another scenario to always reproduce the problem.

It's not very visible right now - the music just stops playing so you can blame it on the network or the swarm - but once you have visible playback/queue indicators it gets obvious something is wrong.

On 8 June 2017 08:36:59 CEST, funkyg notifications@github.com wrote:

hmm that works fine for me (tested with 0.1.3 release). it might be some kind of race condition?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/funkyg/funkytunes/issues/30#issuecomment-307012702

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.