search

funkyg / funkytunes

A streaming music player for Android, using torrents.
GNU General Public License v3.0
122 stars 24 forks source link

Pause on phone call #33

Closed sim6 closed 7 years ago

sim6 commented 7 years ago

Please, could you pause on phone call?

Thanks.

gjedeer commented 7 years ago

@sim6 mind testing funkyg's fix for your issue? APK, if you don't want to build: https://downloads.buddybuild.com/api/download/download-apk?buildID=593a89446d49e50001fc9704&application_variant=debug

sim6 commented 7 years ago

I think buddybuild isn't open source :( so I complied it and works, thank you very much!

gjedeer commented 7 years ago

Hmm, on Android 7 when you install it for the first time (not upgrade) it's asking for permission to "make phone calls". Is there a more granular permission maybe? I've never seen other media player ask for that and guess VLC, for example, supports that.

funkyg commented 7 years ago

youre right, i just found this info: https://developer.android.com/guide/topics/media-apps/volume-and-earphones.html

will try to implement that.

funkyg commented 7 years ago

okay i implemented that in a6bea9f04b537a3b4ac5c76cedf368bae9e42373

gjedeer commented 7 years ago

Nice. Maybe remove the telephony permission too?

funkyg commented 7 years ago

i did that in the previous commint ;)