search

funkyg / funkytunes

A streaming music player for Android, using torrents.
GNU General Public License v3.0
122 stars 24 forks source link

Support TOR and *.onion addresses #9

Open vn971 opened 7 years ago

vn971 commented 7 years ago

By using Tor and *.onion addresses you could totally avoid any country-specific issues like the one raised here: https://github.com/funkyg/funkytunes/issues/7

It should optional, of course, as not all people have Orbot installed.

Thanks

ghost commented 7 years ago

This should only be used to fetch the torrent file, not for the real p2p traffic of course. TOR isn't meant for that.

vn971 commented 7 years ago

Yes, of course.

gjedeer commented 7 years ago

While Onion support would be nice, you can route the regular domains with Orbot by going to settings and choosing "select apps" without support from the app.

vn971 commented 7 years ago

@gjedeer regular domains can be blocked by the tor route you use. What this issue proposes is to use *.onion addresses, which live within the TOR network and don't touch the common web. I think there is a huge difference here in terms of maintenance.

funkyg commented 7 years ago

Looks like here is a onion address for pirate bay (not sure if official or mirror): http://uj3wazyk5u4hnvtk.onion

It would require Orbot installed, and probably an option to enable/disable tor in the funkytunes settings.

Also i dont think we can use tor for magnet download only, because we do both magnet and torrent download with jlibtorrent.

vn971 commented 7 years ago

@funkyg yes, that's the correct one (onion address). I think it's official.

// I don't know about jlibtorrent. Could be a good feature request if it's not present, but well, IDK.