search

funmusicplace / mirlo

An open source audio distribution and patronage platform
https://mirlo.space/
GNU General Public License v3.0
121 stars 23 forks source link

Add time element to player bar #232

Open LouisLouiseKay opened 11 months ago

LouisLouiseKay commented 11 months ago
simonv3 commented 11 months ago

Add a way to scrub through the track to quickly get anyway you want by clicking on the progress bar (actually it's possible there's already a ticket for that and I missed it but I couldn't find it when searching!)

this is already possible, is this not what you're describing? scrubbing

Add a counter that indicates where you are in the song timewise.

This used to exist but certain parties were complaining that there was too much stuff in the player. Also neither bandcamp or spotify show this unless the player is expanded (a state we don't have).

LouisLouiseKay commented 11 months ago

This is so weird I could swear it didn't work yesterday for me, I can't test on the computer though so I'll have to make sure. It definitely doesn't seem to work on mobile though.

For the numbers, Bandcamp does show it, particularly in mobile view where you can see it both near the big button and in track row.

Actually I was asking more for "how to access it", because I would probably see it best in the trackrow. But it could be ok to have it in the player view in large browser windows, and get ridd of it in smaller view. Where I agree it would take a needless amount of space at the bottom.

LouisLouiseKay commented 11 months ago

Tried this today can confirm it doesn't work on Chromium browsers.

simonv3 commented 11 months ago

Actually I was asking more for "how to access it", because I would probably see it best in the trackrow. But it could be ok to have it in the player view in large browser windows, and get ridd of it in smaller view. Where I agree it would take a needless amount of space at the bottom.

It's track.audio.duration and there's a function in client/src/utils/tracks.ts called fmtMSS that will format the duration-in-seconds to the minute timestamp.