search

funmusicplace / mirlo

An open source audio distribution and patronage platform
https://mirlo.space/
GNU General Public License v3.0
123 stars 25 forks source link

Download album breaks again 😭 #82

Closed simonv3 closed 1 year ago

simonv3 commented 1 year ago

Clicking download causes 502 bad gateway. 

Aug 28 09:39:30 AM  info: Getting object from MinIO Bucket track-audio: 7e1f137e-92ee-40f0-bc8d-eb9078e77999/original.wav in /data/downloadCache/1 {"service":"api"}
Aug 28 09:39:30 AM  info: Got stream {"service":"api"}
Aug 28 09:39:32 AM  Everything exists at filePath  /data/downloadCache/1/2 - OK.wav
Aug 28 09:39:32 AM  info: Fetched file for tracks /data/downloadCache/1/2 - OK.wav {"service":"api"}
Aug 28 09:39:32 AM  Killed

Maybe we need to front-load creating a zip when songs are uploaded? It would mean that we have to rebuild the entire archive every time a song gets uploaded, or when the user clicks "publish". That could be a moment when metadata also gets set correctly.

simonv3 commented 1 year ago

Previously https://github.com/funmusicplace/mirlo/issues/70

simonv3 commented 1 year ago

I think this is fixed but if a big enough file comes along it'll probably resurface, and who knows how this'll go with multiple people downloading an album at the same time lol