search

funnelweblog / FunnelWeb

FunnelWeb is an open source blog engine targeted at developers
http://funnelweblog.com/
Other
96 stars 55 forks source link

JS Minification breaks prettify script #30

Closed georged closed 11 years ago

georged commented 11 years ago

Script bundling by default minimises the scripts which works fine most of the time.

It fails however on prettify bundle with the error 

/*
Minification failed. Returning unminified contents.
(74,89-103): run-time warning JS1015: Unterminated string constant: ...
*/

Unfortunately, minification fails only partially and breaks prettifying script. Prettify script is already minified so double-up does not make too much sense (bundling does due to a number of lang-* files).

Not sure if it's related to the Issue #29 but both can be fixed at the same time.

Workaround: set debug="true" on compilation element in web.config - that switches bundling off.

georged commented 11 years ago

I'll give it a shot (need to think about generic handling of minified scripts, I thought that adding .min.js version is supposed to force bundler to pick already minified script but it's not happening for me)