Code refactoring

[jgauffin]

Are you interested in pull requests like this?

I've refectored the code a bit. Would continue to do so for some more things and then start contributing.

[JakeGinnivan]

Looks good, I will pull down locally this weekend and pull in. I would love to have your contributions and refactoring's.

also, I deleted the spam comment on this, first time I have seen github spam :)

[JakeGinnivan]

Sorry for not doing this.

Just ran it all up and got this, I know this was a breaking Autofac change in 2.6 i think which may have been upgraded?

Also, if you take a branch, then make your changes, you can make multiple changes at the same time and multiple pull requests. and your master will always match upstream. Hvae a look at http://code52.org/contributing.html for more info.

Thanks again for the PR, and if you don't have a chance to look into this, I will try and resolve it myself over the weekend and get this in

System.ObjectDisposedException was unhandled by user code
  HResult=-2146232798
  Message=This resolve operation has already ended. When registering components using lambdas, the IComponentContext 'c' parameter to the lambda cannot be stored. Instead, either resolve IComponentContext again from 'c', or resolve a Func<> based factory to create subsequent components from.
  Source=Autofac
  ObjectName=""
  StackTrace:
       at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, IComponentRegistration registration, IEnumerable`1 parameters)
       at Autofac.Core.Resolving.InstanceLookup.ResolveComponent(IComponentRegistration registration, IEnumerable`1 parameters)
       at Autofac.ResolutionExtensions.TryResolveService(IComponentContext context, Service service, IEnumerable`1 parameters, ref Object instance)
       at Autofac.ResolutionExtensions.ResolveService(IComponentContext context, Service service, IEnumerable`1 parameters)
       at Autofac.ResolutionExtensions.Resolve(IComponentContext context, Type serviceType, IEnumerable`1 parameters)
       at Autofac.ResolutionExtensions.Resolve(IComponentContext context, IEnumerable`1 parameters)
       at Autofac.ResolutionExtensions.Resolve(IComponentContext context)
       at FunnelWeb.Eventing.AutofacEventPublisher.Publish(T payload) in AutofacEventPublisher.cs: line 41
       at FunnelWeb.Web.Controllers.WikiController.Page(PageName page, PageModel model) in WikiController.cs: line 131
       at lambda_method(Closure, ControllerBase, Object[])
       at System.Web.Mvc.ActionMethodDispatcher.Execute(ControllerBase controller, Object[] parameters)
       at System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary`2 parameters)
       at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary`2 parameters)
       at System.Web.Mvc.Async.AsyncControllerActionInvoker.<>c__DisplayClass42.<BeginInvokeSynchronousActionMethod>b__41()
       at System.Web.Mvc.Async.AsyncResultWrapper.<>c__DisplayClass8`1.<BeginSynchronous>b__7(IAsyncResult _)
       at System.Web.Mvc.Async.AsyncResultWrapper.WrappedAsyncResult`1.End()
       at System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeActionMethod(IAsyncResult asyncResult)
       at System.Web.Mvc.Async.AsyncControllerActionInvoker.<>c__DisplayClass37.<>c__DisplayClass39.<BeginInvokeActionMethodWithFilters>b__33()
       at System.Web.Mvc.Async.AsyncControllerActionInvoker.<>c__DisplayClass4f.<InvokeActionMethodFilterAsynchronously>b__49()
  InnerException: 

[JakeGinnivan]

Going to close this as I can't pull it in

[JakeGinnivan]

Will reopen once issue is resolved