Update CONTRIBUTING.md - Githubissues

funprog / funbot

MIT License

5 stars 2 forks source link

Update CONTRIBUTING.md #40

Closed hkjlee109 closed 8 years ago

hkjlee109 commented 8 years ago

Issue: #37 #38

[x] Update to have 👎 policy.
[x] Add Issue Filing Convention.
[x] Review.
Contributing to FunBot

Issue Filing Convention
1. It is always welcomed to post an issue.
2. To get proceed, at least 3 approvals(👍) from the members are required.
  Pull Request Merging Convention
3. All the comments SHOULD be addressed prior to merging.
  - To express a refusal on merging, the reviewer SHOULD emoji 👎 on the description.
  - And release the 👎 emoji when solved so that at the merging, there SHOULD be no 👎 left.
4. At least 3 reviewers SHOULD approve.
  - To express an approval, emoji 👍 on the description.
5. If any participant requests specific member for a review (eg. @masunghoon), hold until the member reviews the PR.

FunProg Team

jwChung commented 8 years ago

There is no reason that I don't vote for +1. Thank you for your effort. :)

hkjlee109 commented 8 years ago

@jwChung My pleasure! :)