funtoo / keychain

keychain ssh-agent front-end
http://www.funtoo.org
GNU General Public License v2.0
757 stars 107 forks source link

Fix exit codes #139

Open manolis-andr opened 2 years ago

manolis-andr commented 2 years ago

Failed keychain executions always return success exit code. The problem is that although keychain detects the failures and issues 'exit 1', in the actions of the 'trap' builtin used to cleanup some lock files upon exit, keychain masks the previous exit code by performing another 'exit 0'.

To fix that, remove 'exit 0' from the trap actions to preserve the previous exit code of an internal exit invocation.

mrl5 commented 2 years ago

hello, @manolis-andr - first of all thank you for the PR and sorry that someone responded after ~4 months

the reason why your PR didn't get any attention is that this is a mirror repository.

Funtoo Linux contribution process happens via https://code.funtoo.org

if you're still interested in contributing to Funtoo Linux you might be interested in this links: