search

funtoo / keychain

keychain ssh-agent front-end
http://www.funtoo.org
GNU General Public License v2.0
750 stars 105 forks source link

/bin/sh might not be bash! #57

Closed rjbs closed 7 years ago

rjbs commented 8 years ago

keychain seems to work perfectly well on Solaris, except /bin/sh is not going to be bash, but a really ancient original Bourne-style shell.

We should use /bin/bash to be sure we get bash.

MicroCheapFx commented 8 years ago

I guess this is not an error. If /bin/sh is called in the shebang, it means it has to be /bin/sh to execute the script and not /bin/bash. Some UNIX machines (like synology) does not embed bash. /bin/sh is more standard (even if less everyday used).

rjbs commented 8 years ago

It is an error, because keychain uses bash-specific features like local which are not found in old-school sh. You can't run keychain on Solaris's sh because of that which is exactly while I filed this PR.

The options are probably:

The first seemed simpler.

simonvanderveldt commented 8 years ago

Judging by this PR #49 and these issues #39 #31 keychain should be POSIX compliant. If it isn't it seems like being POSIX compliant is a design goal so maybe the instances where that isn't the case should be fixed?

simonvanderveldt commented 7 years ago

@danielrobbins It seems like your automated migration script didn't work correctly. I doubt the relevant bug is called <tornado.concurrent.Future object at 0x7f806de61828> ;)

danielrobbins commented 7 years ago

Yep, fixed it. Thanks.

danielrobbins commented 7 years ago

This issue has been resolved in the Funtoo Linux bug tracker. Closing on GitHub.

simonvanderveldt commented 7 years ago

@danielrobbins There doesn't seem to be a commit to keychain related to this? Also no mention of a fix in the Funtoo bugtracker's issue https://bugs.funtoo.org/browse/FL-3400 Seems like an accidental close?

rjbs commented 7 years ago

Yeah so… is this actually dealt with?