search

funwithflutter / lit_firebase_auth

Lit Firebase Auth simplifies the process of adding Firebase Authentication to a Flutter application.
MIT License
76 stars 18 forks source link

added suffix icon to control text obscure in password field #17

Closed Imgkl closed 8 months ago

funwithflutter commented 4 years ago

Thanks for the pull request. I'm not opposed to this, and I like the functionality. I'm just not sure from a security perspective what the impact of this is. I know on Android there used to be a problem with password textfields, that when you show a password it gets added to the keyboard dictionary. Meaning entered passwords would be stored in some cache somewhere on the device. Not sure how Flutter deals with this? I'll also do some research.

Imgkl commented 4 years ago

Interesting. Never knew that it's a thing. Storing the password in cache totally defeats the sole purpose of the passwords and security. I'll too do some research on this.

Imgkl commented 4 years ago

Hey, I’ve done some research on this. It’s safe to say there is no security issue in this. Reached out to some people in flutter community and none of them have any problem with this. Plus they pointed many apps including many banking apps use ‘show password’.

Though this is a small change, I just feel like it’s a right way to improve the UX of the user.

ciriousjoker commented 3 years ago

I have implemented this in my own app as well (using custom form). Looks like this:

Screenshot_20201031-164513-01

Haven't had any issues with passwords being stored in my keyboard autocomplete (using Gboard). Also, as a side note: I haven't tried fixing #11 in my form, but if when I figure it out, I'll add a comment there.

Imgkl commented 3 years ago

hey @funwithflutter, So It's been so long and was hoping to get any updates on this. As I said before, this is a simple feature and it is a good UX too.