fupdec / mediaChips

Manage your videos, add any metadata to them and play them.
https://mediachips.app
GNU General Public License v3.0
163 stars 20 forks source link

Renaming tags can break markers #26

Closed mf35 closed 3 years ago

mf35 commented 3 years ago

Alright, i found and isolated an interresting bug.

Put a tag marker on a video, then rename this tag on the tags page. This renaming won't be echoed in the markers database file (dbm.json), resulting in breaking several things when you play this video:

Renaming the tag in dbm.json file accordingly resolved the problem.

fupdec commented 3 years ago

I didn't try to reproduce it but I think problem with updating tags state in player. If add a new tag it will don't appear in player's tags. Need to updating player tags. Temporary solution maybe rerun app after any manipulation with tag name.

mf35 commented 3 years ago

I don't know if i got understood, let me explain with a clearer example:

fupdec commented 3 years ago

After you added tag, renamed or deleted just rerun app. For better understanding how tags connects with player. On start app main window send a copy of object with tags to player window. One time. But it should be every time after tag object changed.

mf35 commented 3 years ago

Ok, right now i have already some tags set. So i just launched a video, added an existing marker tag to it on its timeline, everything's ok. Then i went to tags page, renamed the tag i just used, and relaunched the video. Everything was working, except that the tag's name has not changed on the marker's video (on the timeline and on the markers'list)

So i closed the app and opened it again. And when i re-launched the video, it was worse, like i described it in the first post, no more markers on timeline, can't open playlist and markers list. Then i checked dbm.json file, the tag's name was not changed there, and the problem is solved only when i change the tag's name there. I'm talking about dbm.json, so the markers related file, not the tags related file.

mf35 commented 3 years ago

It's really easy to reproduce, you should try the step by step i gave. :)

fupdec commented 3 years ago

I understand, when you renamed any tag its name don't updating in markers database. It's a mistake, it should be fixed.

mf35 commented 3 years ago

Yes that's it :) I'm sorry, it's not easy to explain.

fupdec commented 3 years ago

Fixed in release v0.7.1