furagu / easy-gd

A simplified Node.js wrapper around GD image manipulation library with extra features making your life easier.
MIT License
25 stars 14 forks source link

Make easy-gd complient with Node 4.x.x #9

Open y-a-v-a opened 9 years ago

y-a-v-a commented 9 years ago

Update node-gd to 1.1.0 and still get it to work with node@0.12.7 also.

furagu commented 9 years ago

Hey Vincent,

thanks for your PR. Probably it is worth to drop the old node.js versions support, so I will investigate the matter and merge.

y-a-v-a commented 9 years ago

Hi thanks for the reply. Yes I think the build breaks for 0.9 and 0.8 due to changes in dependencies. As said, it builds and passes npm test for nodejs 4.1.2 and 0.12.7. No idea how it builds on 0.10.x. I think support for 0.12.x is still valuable, support for 0.10.x can be debatable ;-)

kaanon commented 8 years ago

i'm using this fork. Works great!

Spalland commented 8 years ago

Any news on whether this will be merged?

MatthD commented 8 years ago

Yes y-a-v-a Is working great !!!

y-a-v-a commented 8 years ago

Ok so I modified the configuration for travis a bit so we drop support for nodejs 0.9. As travis shows, still builds nicely on 0.10, 0.12 and 4.3. If you don't mind dropping support for 0.9, you could merge this PR. Regards, Vincent

y-a-v-a commented 8 years ago

@furagu any chance you have time to look into this PR / merge it / publish it to NPM? Would be great.

y-a-v-a commented 8 years ago

Hi @furagu we've added some updates, extended nodejs version support. Could you merge & publish to npm? Or add me as a maintainer in npm so I could publish a new version myself? Thanks in advance!

dekatron commented 8 years ago

@furagu would be great if this could get merged (or if you could add y-a-v-a as a maintainer) on up to date systems with older versions of node I have an issue with node-gyp as it's not compatible with python3 which prevents me from installing easy-gd, on systems with a more recent version of node I can't install because easy-gd isn't compatible. This branch fixes the issue so would be really helpful to anyone in a similar situation.

kodie commented 7 years ago

@furagu +1 for merging this or making @y-a-v-a a maintainer

y-a-v-a commented 7 years ago

Updated easy-gd to use node-gd@1.5.0 and buffertools@2.1.6