furaiev / amazon-cognito-identity-dart-2

Unofficial Amazon Cognito Identity Provider Dart SDK, to easily add user sign-up and sign-in to your mobile and web apps with AWS.
MIT License
187 stars 114 forks source link

remove unused flutter_test dev dependency #73

Closed knaeckeKami closed 4 years ago

knaeckeKami commented 4 years ago

This package has an unused dev_dependency for flutter_test. This causes this package and all dependents to be flagged as incompatible with vanilla (flutter-less) Dart on pub.dev .

This PR removes this dependency (note: this does not affect the example, which still can use flutter)

furaiev commented 4 years ago

@knaeckeKami thank you for PR. Have you managed to successfully pass tests without flutter_test dependency?

knaeckeKami commented 4 years ago

yes!

~/d/amazon-cognito-identity-dart-2 (master)> pub run test
Precompiling executable... (13.6s)
Precompiled test:test.
00:12 +69: All tests passed!
furaiev commented 4 years ago

Thank you!