search

furbrain / STIC

GNU General Public License v3.0
9 stars 5 forks source link

Add menu option to disable screen flip #10

Closed echarlie closed 9 months ago

echarlie commented 9 months ago

Pretty self-explanatory: I find the monitor flip to be easy to accidentally trigger, so I'd like to disable it.

The good part: if you turn off the setting, it applies without a reboot. the bad part, it will not reapply until you reboot. This could be fixed, but I've elected to not add complexity to app.py for now.

Currently this code is running on my SAP6 and behaves as expected.

furbrain commented 9 months ago

Would this be better addressed by increasing the hysteresis on the flip. I.e the flip only happens above a certain angle of roll and this can be increased, to make it less easy to trigger?

I'm wary of having too many settings...

Phil

On Mon, 8 Jan 2024, 11:53 pm echarlie, @.***> wrote:

Pretty self-explanatory: I find the monitor flip to be easy to accidentally trigger, so I'd like to disable it.

The good part: if you turn off the setting, it applies without a reboot. the bad part, it will not reapply until you reboot. This could be fixed, but I've elected to not add complexity to app.py for now.

Currently this code is running on my SAP6 and behaves as expected.

You can view, comment on, or merge this pull request online at:

https://github.com/furbrain/STIC/pull/10 Commit Summary

File Changes

(3 files https://github.com/furbrain/STIC/pull/10/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/furbrain/STIC/pull/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW3PXLKNCIIZN37YXWG3YLYNSBGNAVCNFSM6AAAAABBSHRQT2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TCNBQGUYDOMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

echarlie commented 9 months ago

I could see an argument for either or both, but personally I'd rather have no flip at all. I just propose this instead of me commenting out the code on my personal unit.

Regarding too many settings: mostly agreed. With some other stuff I've been working on, I've hit the point on my unit where it starts having low memory conditions and other instability that I can't attribute, so that is a worry.

furbrain commented 9 months ago

I think on balance I'm going to close this request. However, I'm happy to revisit it if I get more people asking for this feature. I have however, decreased the flip sensitivity with commit 5a16de5