search

fureigh / unbias-me

A Chrome extension to let you review GitHub, LinkedIn and Twitter profiles with minimal attribution information.
https://bit.ly/unbias-me
MIT License
96 stars 6 forks source link

Use CSS to hide user info where possible #35

Closed chrisbodhi closed 7 years ago

chrisbodhi commented 8 years ago

Start to address the issue of content displaying on the page before being hidden by JS. Also refactored some JS for LinkedIn.

dawsbot commented 7 years ago

@chrisbodhi Perhaps it would be more manageable as two separate PR's? Seems like the functionality of css content hiding is different from the LinkedIn JS cleanup. In addition, a before vs. after picture of the LinkedIn changes might make it easier to review.

That is if @fureigh is still maintaining this project. Can't tell

fureigh commented 7 years ago

@dawsbot read my mind. +1 to that suggestion, and my apologies for not responding earlier.

dawsbot commented 7 years ago

@chrisbodhi I personally would ❤️ to see the instant css stuff working asap. That's a big win since the only Chrome review is three star's mentioning the "flash of unhidden content" before the extension operates on the DOM.

Let me know if there is any way I can help on this, this extension is 🔑 and I want to enable an idea like this to succeed more.

chrisbodhi commented 7 years ago

Thanks for the suggestion, @dawsbot and for getting going with the Github CSS portion. I'll have some time later today to revisit this PR and get it 👌

dawsbot commented 7 years ago

@chrisbodhi No worries, thanks for chiming in. Any thoughts? I supplied screenshots so that you can see the current appearance with the extension enabled.

You don't need to have master up-to-date with the Chrome store, right? I was thinking if that was the hassle just forget it for now? Tell me what I can do to help, I'm dedicated to helping this extension work well and eliminate bias 👌

chrisbodhi commented 7 years ago

I like this splitting up the CSS-ifying by domain. Since @dawsbot has already (gotten Github handled)[https://github.com/fureigh/unbias-me/pull/37] and LinkedIn completely changed their site, I'm going to close this PR in favor of a separate PRs for Twitter, LinkedIn, etc. I'll bring over my work here for Twitter first, in a new PR.