furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
483 stars 21 forks source link

fix: Gracefully handle no schedule in Bump() #103

Closed irvinlim closed 1 year ago

irvinlim commented 1 year ago

Closes #101.

codecov[bot] commented 1 year ago

Codecov Report

Base: 63.50% // Head: 63.53% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (812082d) compared to base (5ad6ccc). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #103 +/- ## ========================================== + Coverage 63.50% 63.53% +0.03% ========================================== Files 205 205 Lines 10958 10957 -1 ========================================== + Hits 6959 6962 +3 + Misses 3621 3619 -2 + Partials 378 376 -2 ``` | [Impacted Files](https://codecov.io/gh/furiko-io/furiko/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io) | Coverage Δ | | |---|---|---| | [pkg/execution/util/schedule/schedule.go](https://codecov.io/gh/furiko-io/furiko/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2V4ZWN1dGlvbi91dGlsL3NjaGVkdWxlL3NjaGVkdWxlLmdv) | `77.32% <100.00%> (+1.60%)` | :arrow_up: | | [pkg/utils/heap/heap.go](https://codecov.io/gh/furiko-io/furiko/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL3V0aWxzL2hlYXAvaGVhcC5nbw==) | `100.00% <0.00%> (+1.07%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.