furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
478 stars 21 forks source link

feat(cli): Implement --watch flag #118

Closed irvinlim closed 1 year ago

irvinlim commented 1 year ago
  1. Implements --watch for list subcommands.
  2. Refactor flag initialization for subcommands.
  3. Re-implement TablePrinter using github.com/liggitt/tabwriter.
  4. Change YAML and JSON output for lists from metav1.List to individual documents/objects.
codecov[bot] commented 1 year ago

Codecov Report

Base: 64.34% // Head: 64.47% // Increases project coverage by +0.13% :tada:

Coverage data is based on head (ad0ef54) compared to base (1efeecb). Patch coverage: 83.26% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== + Coverage 64.34% 64.47% +0.13% ========================================== Files 207 208 +1 Lines 11143 11244 +101 ========================================== + Hits 7170 7250 +80 - Misses 3580 3603 +23 + Partials 393 391 -2 ``` | [Impacted Files](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io) | Coverage Δ | | |---|---|---| | [pkg/cli/cmd/watch.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvd2F0Y2guZ28=) | `35.48% <35.48%> (ø)` | | | [pkg/cli/cmd/cmd\_list\_job.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX2xpc3Rfam9iLmdv) | `81.06% <80.48%> (+2.35%)` | :arrow_up: | | [pkg/cli/cmd/cmd\_list\_jobconfig.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX2xpc3Rfam9iY29uZmlnLmdv) | `88.80% <80.95%> (+0.79%)` | :arrow_up: | | [pkg/cli/cmd/common.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY29tbW9uLmdv) | `51.80% <84.61%> (+6.80%)` | :arrow_up: | | [pkg/runtime/testing/command.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL3J1bnRpbWUvdGVzdGluZy9jb21tYW5kLmdv) | `77.16% <95.34%> (+6.19%)` | :arrow_up: | | [pkg/cli/cmd/cmd\_get.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX2dldC5nbw==) | `88.46% <100.00%> (+4.25%)` | :arrow_up: | | [pkg/cli/cmd/cmd\_get\_job.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX2dldF9qb2IuZ28=) | `76.35% <100.00%> (+1.18%)` | :arrow_up: | | [pkg/cli/cmd/cmd\_get\_jobconfig.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX2dldF9qb2Jjb25maWcuZ28=) | `75.30% <100.00%> (+2.18%)` | :arrow_up: | | [pkg/cli/cmd/cmd\_list.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX2xpc3QuZ28=) | `90.00% <100.00%> (+4.28%)` | :arrow_up: | | [pkg/cli/printer/printer.go](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9wcmludGVyL3ByaW50ZXIuZ28=) | `100.00% <100.00%> (ø)` | | | ... and [6 more](https://codecov.io/gh/furiko-io/furiko/pull/118?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.