search

furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
478 stars 21 forks source link

feat(cli): Add CLI enhancements for furiko run command #120

Closed irvinlim closed 1 year ago

irvinlim commented 1 year ago

Added several quality-of-life improvements for flags for furiko run.

  1. Add --after shorthand flag for --at.
  2. Add --enqueue shorthand flag for --concurrency-policy=Enqueue.
  3. Add --generate-name flag.
  4. Add --option-values flag.
  5. Validate --concurrency-policy flag.
  6. Update usage examples for furiko run.
  7. Fixes small typo in --no-interactive flag's help.
codecov[bot] commented 1 year ago

Codecov Report

Base: 68.63% // Head: 68.76% // Increases project coverage by +0.13% :tada:

Coverage data is based on head (206eaee) compared to base (df46c55). Patch coverage: 96.90% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== + Coverage 68.63% 68.76% +0.13% ========================================== Files 188 188 Lines 9584 9644 +60 ========================================== + Hits 6578 6632 +54 - Misses 2645 2649 +4 - Partials 361 363 +2 ``` | [Impacted Files](https://codecov.io/gh/furiko-io/furiko/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io) | Coverage Δ | | |---|---|---| | [pkg/cli/cmd/common.go](https://codecov.io/gh/furiko-io/furiko/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY29tbW9uLmdv) | `53.48% <57.14%> (+1.68%)` | :arrow_up: | | [apis/execution/v1alpha1/jobconfig\_types.go](https://codecov.io/gh/furiko-io/furiko/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-YXBpcy9leGVjdXRpb24vdjFhbHBoYTEvam9iY29uZmlnX3R5cGVzLmdv) | `100.00% <100.00%> (ø)` | | | [pkg/cli/cmd/cmd\_run.go](https://codecov.io/gh/furiko-io/furiko/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX3J1bi5nbw==) | `80.00% <100.00%> (+4.43%)` | :arrow_up: | | [pkg/execution/validation/validation.go](https://codecov.io/gh/furiko-io/furiko/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2V4ZWN1dGlvbi92YWxpZGF0aW9uL3ZhbGlkYXRpb24uZ28=) | `90.95% <100.00%> (-0.08%)` | :arrow_down: | | [pkg/cli/prompt/prompt.go](https://codecov.io/gh/furiko-io/furiko/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9wcm9tcHQvcHJvbXB0Lmdv) | `78.98% <0.00%> (-1.92%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.