furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
478 stars 21 forks source link

feat(execution): Add JobState field to JobStatus #123

Closed irvinlim closed 1 year ago

irvinlim commented 1 year ago

Introduces JobState, which is a simplified version of JobPhase.

The value of JobState is intended to match the non-nil value in JobCondition exactly, and will be written to JobStatus for greater clarity and convenience.

codecov[bot] commented 1 year ago

Codecov Report

Base: 69.56% // Head: 69.53% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (8b1d39e) compared to base (a171da7). Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ========================================== - Coverage 69.56% 69.53% -0.03% ========================================== Files 192 192 Lines 9781 9802 +21 ========================================== + Hits 6804 6816 +12 - Misses 2613 2622 +9 Partials 364 364 ``` | [Impacted Files](https://codecov.io/gh/furiko-io/furiko/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io) | Coverage Δ | | |---|---|---| | [apis/execution/v1alpha1/job\_types.go](https://codecov.io/gh/furiko-io/furiko/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-YXBpcy9leGVjdXRpb24vdjFhbHBoYTEvam9iX3R5cGVzLmdv) | `85.36% <0.00%> (-14.64%)` | :arrow_down: | | [pkg/execution/controllers/jobcontroller/util.go](https://codecov.io/gh/furiko-io/furiko/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2V4ZWN1dGlvbi9jb250cm9sbGVycy9qb2Jjb250cm9sbGVyL3V0aWwuZ28=) | `77.94% <72.72%> (-1.01%)` | :arrow_down: | | [pkg/cli/cmd/cmd\_get\_job.go](https://codecov.io/gh/furiko-io/furiko/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2NsaS9jbWQvY21kX2dldF9qb2IuZ28=) | `76.43% <100.00%> (+0.07%)` | :arrow_up: | | [.../execution/controllers/jobcontroller/reconciler.go](https://codecov.io/gh/furiko-io/furiko/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io#diff-cGtnL2V4ZWN1dGlvbi9jb250cm9sbGVycy9qb2Jjb250cm9sbGVyL3JlY29uY2lsZXIuZ28=) | `71.95% <100.00%> (+0.13%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=furiko-io)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.