furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
484 stars 21 forks source link

chore(core): Refactor options package names #66

Closed irvinlim closed 2 years ago

irvinlim commented 2 years ago

Updates naming of symbols and files in the core/options package to be more standardized.

Also exposed a GetOptionDefaultValue which returns the raw default value prior to evaluation.

codecov[bot] commented 2 years ago

Codecov Report

Merging #66 (c5ebcd7) into main (a55d7a2) will decrease coverage by 0.13%. The diff coverage is 87.64%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   61.06%   60.92%   -0.14%     
==========================================
  Files         168      170       +2     
  Lines        8447     8486      +39     
==========================================
+ Hits         5158     5170      +12     
- Misses       3047     3070      +23     
- Partials      242      246       +4     
Impacted Files Coverage Δ
pkg/core/options/substitution.go 100.00% <ø> (ø)
pkg/core/options/default.go 65.16% <63.15%> (-11.76%) :arrow_down:
pkg/core/options/mutation.go 95.00% <95.00%> (ø)
pkg/core/options/validation.go 97.93% <97.93%> (-2.07%) :arrow_down:
pkg/core/options/options.go 90.24% <100.00%> (-4.02%) :arrow_down:
pkg/core/options/util.go 100.00% <100.00%> (ø)
pkg/execution/mutation/mutation.go 88.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a55d7a2...c5ebcd7. Read the comment docs.