furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
484 stars 21 forks source link

chore: Move console to separate package #69

Closed irvinlim closed 2 years ago

irvinlim commented 2 years ago

The github.com/hinshun/vt10x package does not support Windows:

../../../../pkg/mod/github.com/hinshun/vt10x@v0.0.0-20220119200601-820417d04eec/vt_other.go:26:8: t.cur.attr undefined (type Cursor has no field or method attr, but does have Attr)
../../../../pkg/mod/github.com/hinshun/vt10x@v0.0.0-20220119200601-820417d04eec/vt_other.go:27:8: t.cur.attr undefined (type Cursor has no field or method attr, but does have Attr)

Since we only use it for unit tests, we should chuck it into its own package so that it does not need to be imported when building the CLI.

codecov[bot] commented 2 years ago

Codecov Report

Merging #69 (f50393a) into main (1b52a38) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   62.61%   62.61%           
=======================================
  Files         196      196           
  Lines        9825     9825           
=======================================
  Hits         6152     6152           
  Misses       3363     3363           
  Partials      310      310           
Impacted Files Coverage Δ
pkg/cli/console/console.go 81.25% <ø> (ø)
pkg/cli/streams/streams.go 50.00% <100.00%> (ø)
pkg/runtime/testing/command.go 75.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b52a38...f50393a. Read the comment docs.