search

furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
484 stars 21 forks source link

feat(api): Update maxAttempts to int64 #78

Closed irvinlim closed 2 years ago

irvinlim commented 2 years ago

Updates maxAttempts to be int64 instead, there is no need to use int32.

codecov[bot] commented 2 years ago

Codecov Report

Merging #78 (f557758) into main (b94aa78) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files         197      197           
  Lines        9872     9872           
=======================================
  Hits         6179     6179           
  Misses       3380     3380           
  Partials      313      313
Impacted Files Coverage Δ
apis/execution/v1alpha1/job_types.go 100.00% <ø> (ø)
apis/execution/v1alpha1/zz_generated.deepcopy.go 60.48% <100.00%> (ø)
pkg/execution/mutation/mutation.go 88.08% <100.00%> (ø)
pkg/execution/util/job/task_utils.go 94.23% <100.00%> (ø)
pkg/execution/validation/validation.go 91.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b94aa78...f557758. Read the comment docs.