search

furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
483 stars 21 forks source link

feat(execution): Avoid using activeDeadlineSeconds to kill tasks #85

Closed irvinlim closed 2 years ago

irvinlim commented 2 years ago

Closes #64. Also helps #63.

Avoids using activeDeadlineSeconds to kill tasks, instead it will use API deletion instead, which supports graceful termination.

codecov[bot] commented 2 years ago

Codecov Report

Merging #85 (d37f97c) into main (9e17087) will decrease coverage by 0.14%. The diff coverage is 86.04%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   62.87%   62.72%   -0.15%     
==========================================
  Files         200      200              
  Lines       10434    10287     -147     
==========================================
- Hits         6560     6453     -107     
+ Misses       3517     3486      -31     
+ Partials      357      348       -9
Impacted Files Coverage Δ
apis/config/v1alpha1/dynamicconfig_types.go 100.00% <ø> (ø)
apis/config/v1alpha1/zz_generated.deepcopy.go 10.45% <0.00%> (+0.16%) :arrow_up:
apis/execution/v1alpha1/job_types.go 100.00% <ø> (ø)
...g/execution/taskexecutor/podtaskexecutor/labels.go 100.00% <ø> (ø)
.../execution/controllers/jobcontroller/reconciler.go 71.09% <83.05%> (+0.16%) :arrow_up:
...execution/taskexecutor/podtaskexecutor/pod_task.go 90.64% <100.00%> (+4.52%) :arrow_up:
pkg/execution/util/job/condition.go 95.52% <100.00%> (+0.28%) :arrow_up:
pkg/execution/util/job/phase.go 93.75% <100.00%> (ø)
pkg/execution/util/job/timeout.go 100.00% <100.00%> (ø)
pkg/utils/ktime/time.go 92.30% <100.00%> (+0.41%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e17087...d37f97c. Read the comment docs.