search

furiko-io / furiko

Kubernetes cron and batch job platform
https://furiko.io
Apache License 2.0
483 stars 21 forks source link

feat(jobcontroller): Handle killJob based on ParallelCompletionStrategy #87

Closed irvinlim closed 2 years ago

irvinlim commented 2 years ago

Closes #83, #71.

Simply adopts the existing handleKillJob routine to kill tasks when they should be killed according to the ParallelStatus.Complete.

codecov[bot] commented 2 years ago

Codecov Report

Merging #87 (bb3f2db) into main (40c5e95) will increase coverage by 0.10%. The diff coverage is 70.73%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   62.76%   62.87%   +0.10%     
==========================================
  Files         200      200              
  Lines       10297    10334      +37     
==========================================
+ Hits         6463     6497      +34     
- Misses       3486     3489       +3     
  Partials      348      348
Impacted Files Coverage Δ
.../execution/controllers/jobcontroller/reconciler.go 71.82% <70.00%> (+0.73%) :arrow_up:
pkg/execution/controllers/jobcontroller/util.go 78.94% <70.96%> (-9.52%) :arrow_down:
pkg/execution/util/job/phase.go 100.00% <0.00%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40c5e95...bb3f2db. Read the comment docs.