Closed irvinlim closed 2 years ago
Merging #88 (ad6a910) into main (25d2757) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 62.87% 62.88% +0.01%
==========================================
Files 200 200
Lines 10334 10342 +8
==========================================
+ Hits 6497 6504 +7
- Misses 3489 3490 +1
Partials 348 348
Impacted Files | Coverage Δ | |
---|---|---|
pkg/execution/mutation/mutation.go | 89.09% <100.00%> (+5.35%) |
:arrow_up: |
...kg/execution/controllers/croncontroller/metrics.go | 14.28% <0.00%> (-85.72%) |
:arrow_down: |
pkg/runtime/reconciler/metrics.go | 42.10% <0.00%> (-26.32%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 25d2757...ad6a910. Read the comment docs.
Bug Reproduction
Trying to apply the following YAML results in not being able to save:
The following error is displayed:
Bugfix
By right, we should also add default values for JobTemplate in JobConfigSpec. The default value should be set to
AllSuccessful
.