furiosa-ai / device-api

APIs that offers NPU devices' information and allow to control the devices
Apache License 2.0
5 stars 8 forks source link

Refactoring `DeviceConfig` related codes #61

Closed sukyoungjeong-furiosa closed 1 year ago

sukyoungjeong-furiosa commented 1 year ago

Changes

sukyoungjeong-furiosa commented 1 year ago

@libc-furiosa, Can I ask for a review on this PR? This is a refactoring PR only with some minor fixes as mentioned above. (1) enum DeviceConfig => struct DeviceConfig w/ private inner struct but no change in logic. (33fac065) (2) minor change in struct NotDetermined (6327b332) preventing constructing it from user codes.

- pub struct NotDetermined;
+ pub struct NotDetermined {
+    pub(crate) _priv: (),
+}