search

furiosa-ai / furiosa-models

FuriosaAI Model Zoo Project
https://furiosa-ai.github.io/furiosa-models/
Apache License 2.0
9 stars 6 forks source link

Rename .ci to tekton & move Dockerfile to docker/ #161

Closed furiosamg closed 1 year ago

furiosamg commented 1 year ago

Follow other projects' directory scheme.

.ci -> tekton ./Dockerfile -> ./docker/Dockerfile Added new Dockerfile for lint (./docker/lint/Dockerfile)

furiosamg commented 1 year ago

build-and-push 단계에 성공적으로 진입했으므로 ready for review로 바꾸겠습니다. lint 용 dockerfile은 다른 pr의 ci 에서 정상작동하는 것을 확인했습니다. #160 를 머지하기 위해 먼저 머지가 필요합니다.

furiosamg commented 1 year ago

그냥 python3.9 docker image 에서 시작하고 linter등을 task 에서 까는 것이 나을 것 같네요 굳이 새로운 이미지를 관리할 필요가 없어보여서요.. 리뷰 요청 드리고 작업 다시 들어가서 죄송합니다.

furiosa-infra commented 1 year ago

Pip freeze result for ssd-mobilenet

pip freeze result
aiobotocore==2.5.2
aiofiles==22.1.0
aiohttp==3.8.5
aiohttp-retry==2.8.3
aioitertools==0.11.0
aiosignal==1.3.1
amqp==5.1.1
antlr4-python3-runtime==4.9.3
appdirs==1.4.4
async-timeout==4.0.2
asyncssh==2.13.2
atpublic==4.0
attrs==23.1.0
billiard==4.1.0
boto3==1.26.161
botocore==1.29.161
celery==5.3.1
certifi==2023.7.22
cffi==1.15.1
charset-normalizer==3.2.0
click==8.1.6
click-didyoumean==0.3.0
click-plugins==1.1.1
click-repl==0.3.0
colorama==0.4.6
configobj==5.0.8
contourpy==1.1.0
cryptography==41.0.2
cycler==0.11.0
Cython==3.0.0
dictdiffer==0.9.0
diskcache==5.6.1
distro==1.8.0
dpath==2.1.6
dulwich==0.21.5
dvc==3.7.0
dvc-data==2.6.0
dvc-http==2.30.2
dvc-objects==0.23.1
dvc-render==0.5.3
dvc-s3==2.23.0
dvc-studio-client==0.11.0
dvc-task==0.3.0
exceptiongroup==1.1.2
filelock==3.12.2
flatten-dict==0.4.2
flufl.lock==7.1.1
fonttools==4.41.1
frozenlist==1.4.0
fsspec==2023.6.0
funcy==2.0
furiosa-common==0.9.1
furiosa-models @ file:///app
furiosa-native-postprocess==0.9.0.dev0
furiosa-registry==0.9.1
furiosa-runtime==0.9.1
gitdb==4.0.10
GitPython==3.1.32
grandalf==0.8
hydra-core==1.3.2
idna==3.4
importlib-resources==6.0.0
iniconfig==2.0.0
iterative-telemetry==0.0.8
jmespath==1.0.1
kiwisolver==1.4.4
kombu==5.3.1
markdown-it-py==3.0.0
matplotlib==3.7.2
mdurl==0.1.2
multidict==6.0.4
multipledispatch==1.0.0
nanotime==0.5.2
networkx==3.1
numpy==1.25.1
nvidia-cublas-cu11==11.10.3.66
nvidia-cuda-nvrtc-cu11==11.7.99
nvidia-cuda-runtime-cu11==11.7.99
nvidia-cudnn-cu11==8.5.0.96
omegaconf==2.3.0
opencv-python-headless==4.8.0.74
orjson==3.9.2
packaging==23.1
pandas==1.5.3
pathspec==0.11.1
Pillow==10.0.0
platformdirs==3.9.1
pluggy==1.2.0
prompt-toolkit==3.0.39
psutil==5.9.5
py-cpuinfo==9.0.0
pycocotools==2.0.6
pycparser==2.21
pydantic==1.10.11
pydot==1.4.2
pygit2==1.12.2
Pygments==2.15.1
pygtrie==2.5.0
pyparsing==3.0.9
pytest==7.4.0
pytest-asyncio==0.17.2
pytest-benchmark==4.0.0
python-dateutil==2.8.2
pytz==2023.3
PyYAML==6.0.1
requests==2.31.0
rich==13.4.2
ruamel.yaml==0.17.32
ruamel.yaml.clib==0.2.7
s3fs==2023.6.0
s3transfer==0.6.1
scmrepo==1.0.4
shortuuid==1.0.11
shtab==1.6.2
six==1.16.0
smmap==5.0.0
sqltrie==0.7.0
tabulate==0.9.0
toml==0.10.2
tomli==2.0.1
tomlkit==0.11.8
torch==1.13.1
torchvision==0.14.1
tqdm==4.65.0
typing_extensions==4.7.1
tzdata==2023.3
urllib3==1.26.16
vine==5.0.0
voluptuous==0.13.1
wcwidth==0.2.6
wrapt==1.15.0
yarl==1.9.2
zc.lockfile==3.0.post1
zipp==3.16.2
furiosamg commented 1 year ago

regression test trigger는 텍톤 관련 변경들이 있어서 혹시 깨지는 건 아닐까 하고 실행해 본 것이라 이 PR과 무관합니다.

furiosa-infra commented 1 year ago

cdb8eb8 ci: use python default docker image for lint


----------------------------------------------------------------------------------------------------- benchmark: 2 tests ----------------------------------------------------------------------------------------------------
Name (time in ms)                                                Min                 Max               Mean            StdDev             Median               IQR            Outliers      OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_mlcommons_ssd_mobilenet_with_native_rust_pp_accuracy     6.9168 (1.0)       36.7942 (1.0)      12.8036 (1.0)      2.6165 (1.0)      12.2951 (1.0)      3.4583 (1.0)       1611;37  78.1030 (1.0)        5000           1
test_mlcommons_ssd_mobilenet_accuracy                         9.3614 (1.35)     263.8359 (7.17)     15.4522 (1.21)     4.6460 (1.78)     15.0536 (1.22)     3.7796 (1.09)       498;37  64.7157 (0.83)       5000           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean
furiosa-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: furiosamg, sukyoungjeong-furiosa

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/furiosa-ai/furiosa-models/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment