search

furious-luke / django-address

A Django address model and field. Addresses may be specified by address components or by performing an automatic Google Maps lookup.
BSD 3-Clause "New" or "Revised" License
430 stars 180 forks source link

Use tox to test against various Python versions #151

Closed furious-luke closed 3 years ago

furious-luke commented 3 years ago

We've still got some Python compatibility code in the code, and I think it's worth ensuring our tests pass with both Python 2 and 3. tox can help us setup these tests locally, and integrate them into our CI scripts.

furious-luke commented 3 years ago

So, it looks like the code no longer supports Python 2 (depends on features of Django v2+, which are Python 3.5+ only). So, we'd probably want to run tox against only the relevant Python 3 versions, and remove any Python 2 backwards compatible code.

banagale commented 3 years ago

I seem to remember debating whether to continue supporting Python 2, but then finding that some 3+ dependency had existed for some time anyway. I searched and couldn't find the notes about it, but I also did not scrub for code indicating support for 2.

furious-luke commented 3 years ago

Yeah it looked like we were trying to support Python 2, but I'm pretty comfortable dropping support for it, especially given the code would have actually been throwing errors for anyone using Python 2 for quite a while now.

banagale commented 3 years ago

Ya, that was my determination. I was hemming and hawing over it and then saw that it was a moot point already.

I think I had this conversation publicly but alas haven't put my hand on it.