search

furious / LiveSplit.AutoStreamMarker

Automatic marks runs split in your livestreams VOD
6 stars 0 forks source link

Avoid showing "You are not streaming" popup #1

Open ComplexPlane opened 3 years ago

ComplexPlane commented 3 years ago

When I use Livesplit during an offline run, the "You are not streaming" popup opens every time. This shouldn't happen - it causes my game to minimize, and I'm usually quite aware when I'm not streaming. I think the plugin should simply not mark stream sections if you're offline, or at bare minimum not show this dialog box after the first time.

furious commented 3 years ago

Thanks for pointing this out, I can remove it since it was added only for testing purposes and I forgot to remove it.

ComplexPlane commented 3 years ago

Gotcha, that'd be great

On Sun, Jul 25, 2021, 3:41 PM furious @.***> wrote:

Thanks for pointing this out, I can remove it since it was added only for testing purposes and I forgot to remove it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/furious/LiveSplit.AutoStreamMarker/issues/1#issuecomment-886248248, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDIUDZOATIZSGOOHIKABHDTZRSHXANCNFSM5A5SEECQ .

furious commented 3 years ago

I was looking at the code and that notification should only appear the first time, does it show every split or in resets?

ComplexPlane commented 3 years ago

It shows once every time I start Livesplit when my stream isn't running

On Sun, Jul 25, 2021, 3:50 PM furious @.***> wrote:

I was looking at the code and that notification should only appear the first time, does it show every split or in resets?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/furious/LiveSplit.AutoStreamMarker/issues/1#issuecomment-886249136, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDIUD2BCSCDFDOKWLDOM2TTZRTIDANCNFSM5A5SEECQ .

furious commented 3 years ago

Do you mean it only shows the first time you start the very first run after opening the application?

ComplexPlane commented 3 years ago

I believe so yes

On Sun, Jul 25, 2021, 4:00 PM furious @.***> wrote:

Do you mean it only shows the first time you start the very first run after opening the application?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/furious/LiveSplit.AutoStreamMarker/issues/1#issuecomment-886250351, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDIUD4CW7TVXJMENMBUQ7TTZRUMRANCNFSM5A5SEECQ .

furious commented 3 years ago

So it's actually working as intended, but I'll add an option that you can disable that notification