search

furkan3ayraktar / clojure-polylith-realworld-example-app

Clojure, Polylith and Ring codebase containing real world examples (CRUD, auth, advanced patterns, etc) that adheres to the RealWorld spec and API.
MIT License
449 stars 79 forks source link

Why '-table' suffix on comment but not on other tables? #1

Closed jacekschae closed 6 years ago

jacekschae commented 6 years ago

Question

In the clojure.realworld.database.schema you define comment-table and all other tables don't have the -table suffix. Is there a reason for that? Most probably I have limited view on this and trying to figure out what is the rationale here.

Thanks for creating this!

furkan3ayraktar commented 6 years ago

Thanks for pointing it out.

I was trying several things from the beginning so this must be a leftover. I don't remember any specific reason to not just use comment. I'll fix it right away.

furkan3ayraktar commented 6 years ago

Ah I remembered when I checked. comment is a function from Clojure's core library. I used comment-table in order to not conflict with it.

jacekschae commented 6 years ago

Of coures! Now when you mention this it all makes sense. More or less going through it line by line. I'm more of a front-end guy, at least when it comes to Clojure. I appreciate so much the work you put into Polylith. If I find some other things I'll probably bug you again.

furkan3ayraktar commented 6 years ago

Perfect! Keep opening issues for the problems you find. We can make it a perfect example for others by fixing everything.