Closed PEZ closed 1 year ago
This is great! Thank you for the quick changes to Calva!
I also made the jack-in sequence automatically start the API server. Dunno if you had reasons not to do it that way?
I think you added the sequence back then, and I did not check it 😂 I think it makes sense to start the server.
I will investigate the CORS issue and ensure this project can be started and connected to a conduit frontend with minimal steps.
I also made the jack-in sequence automatically start the API server. Dunno if you had reasons not to do it that way?
I think you added the sequence back then, and I did not check it 😂
🤣
This should be good to now, afaik. I used this project as one of my drivers when making the changes to Calva.
I've re-worded comments in the settings.json
and restructured the Readme. I also ran it against the jacekschae/conduit frontend. I didn't get any CORS issues. Just changing api-url
in src/conduit/events.cljs
file to (def api-url "http://localhost:6003/api")
was enough to get it work.
Adapting the example to utilize the changes in this PR:
NB: Don't merge until ^that^ PR is merged into Calva
I also made the jack-in sequence automatically start the API server. Dunno if you had reasons not to do it that way?
There are to connect sequences defined here, one for jack-in and one for connecting to a running REPL. The latter opens up for two workflows:
server.clj
code.server.clj
code.Apropos the change in
env.edn
When I started the ClojureScript conduit example, I ran into CORS troubles. I already had a server running at port 3000, causing the
conduit
web server to start at port 3001. Figured that this app could be prepared for that scenario. 😄Maybe I did something wrong there because I diden't get the conduit app to work. I still get a CORS error in the dev console. And on the server I see this in the Jack-in terminal:
I should probably test with some other conduit app, but I am running out of time here. Maybe you can see what I did wrong?