search

furkan3ayraktar / clojure-polylith-realworld-example-app

Clojure, Polylith and Ring codebase containing real world examples (CRUD, auth, advanced patterns, etc) that adheres to the RealWorld spec and API.
MIT License
449 stars 79 forks source link

Add ability to update article tags #7

Closed zelark closed 5 years ago

zelark commented 5 years ago

Although it's out of the spec, I believe it makes sense to add. Especially that the official demo allows you to update article tags.

zelark commented 5 years ago

Btw, I added a little description above. @furkan3ayraktar, what do you think? If some additional changes required, I will do it.

zelark commented 5 years ago

Hi! How's it doing?

zelark commented 5 years ago

Found out that there was a problem with previous solution, it didn't take into account a case when user wants to delete all the tags from an article. So I added one more test, and fixed the problem.

furkan3ayraktar commented 5 years ago

Hi @zelark, thanks for taking time to add this!

I also feel that it makes sense to add update article functionality (and many others), however I don't want to go beyond the RealWorld specs. I'll keep this PR here, so if people visiting repo needs it, they can use your code.