furkantektas / timeline_list

Timeline widget for flutter
MIT License
392 stars 89 forks source link

Added the ability to set the ListView scroll physics #1

Closed JJCLane closed 5 years ago

JJCLane commented 5 years ago

This is necessary when using the TimeLine within a Column and when shrinkWrap is set to true, otherwise you can't get the correct scrolling behaviour.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1 into master will decrease coverage by 1.36%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   99.53%   98.16%   -1.37%     
==========================================
  Files           4        4              
  Lines         214      218       +4     
==========================================
+ Hits          213      214       +1     
- Misses          1        4       +3
Impacted Files Coverage Δ
lib/timeline.dart 100% <100%> (ø) :arrow_up:
lib/src/timeline_painter.dart 96.59% <0%> (-3.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 126f420...33e81d5. Read the comment docs.

furkantektas commented 5 years ago

Yes it was needed, indeed. Thanks @JJCLane :)