search

furkantektas / timeline_list

Timeline widget for flutter
MIT License
392 stars 89 forks source link

Null Safety migration and general framework updates for the example files. #16

Closed samramez closed 3 years ago

samramez commented 3 years ago

this PR is addressing two major updates:

1. Null Saftey migration

Migrated the project to Null Safety by identifying required properties for each function.

2. Android and iOS version updates:

Updating Android and iOS versions to the latest releases. This would eliminate the following message when running the project:

Screen Shot 2021-05-04 at 9 28 42 PM
codecov[bot] commented 3 years ago

Codecov Report

Merging #16 (19463ae) into master (0637916) will decrease coverage by 0.00%. The diff coverage is 98.66%.

:exclamation: Current head 19463ae differs from pull request most recent head 1358d09. Consider uploading reports for the commit 1358d09 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   99.53%   99.53%   -0.01%     
==========================================
  Files           4        4              
  Lines         216      215       -1     
==========================================
- Hits          215      214       -1     
  Misses          1        1
Impacted Files Coverage Δ
lib/src/timeline_item.dart 98.82% <96.55%> (-0.02%) :arrow_down:
lib/src/timeline_painter.dart 100.00% <100.00%> (ø)
lib/timeline.dart 100.00% <100.00%> (ø)
lib/timeline_model.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02d997a...1358d09. Read the comment docs.

samramez commented 3 years ago

retest

samramez commented 3 years ago

I also opened https://github.com/furkantektas/timeline_list/pull/17 it's identical to this PR and I was hoping the test coverage report would get regenerated, but it didn't.

the existing test coverage report above is not up to date with the latest changes.