search

furqanZafar / react-selectize

http://furqanzafar.github.io/react-selectize/
Apache License 2.0
704 stars 138 forks source link

Fix tether and dropdown-direction compatibility with bootstrap #143

Closed howardjing closed 7 years ago

howardjing commented 7 years ago

I ran into some issues with using the following properties:

when using react-selectize within an application with bootstrap3 css included.

The issue seems to be a clash between bootstrap and react-selectize over the .dropdown-menu class name. I renamed dropdown-menu to rs-dropdown-menu as a sanity check, and it fixed the issues I was having.

I don't think this current PR is a great solution as it would break any existing customized css people have made for the dropdown menu, but this was the quickest fix for my purposes.

@furqanZafar I'd appreciate your input as to what you think is the best way to solve this.

See https://github.com/furqanZafar/react-selectize/issues/137 for more details.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.6%) to 86.012% when pulling ffe679b4bd00d74a5546ef99410c5415e054891e on howardjing:dropdown-css into 9e936fa3083777b07b003038b6b0db3306f571e5 on furqanZafar:master.

htsui commented 7 years ago

I've put this PR up on npm under 'react-selectize-bs'

Gribbs commented 7 years ago

react-selectize-bs fixed the issue for me! Thanks

hwaterke commented 7 years ago

react-selectize-bs doesn't solve the problem and is already several versions behind. I think this needs to be merged. It is anyway not a good idea to use very generic css classnames in such a component.

mnieber commented 7 years ago

I see the changes were approved, great :-). @bruno-sartori @howardjing is this a matter now of rebasing the branch?

howardjing commented 7 years ago

Ah, thanks for the heads up. I'll update the PR later today.

howardjing commented 7 years ago

187 has the rebased code