furqanZafar / react-selectize

http://furqanzafar.github.io/react-selectize/
Apache License 2.0
704 stars 138 forks source link

Unnecessary batch update maybe? #203

Open iofreddy85 opened 6 years ago

iofreddy85 commented 6 years ago

Is this line really needed?

https://github.com/furqanZafar/react-selectize/blob/d3f707235cf4f8fca3646421861688678f70f045/src/SimpleSelect.ls#L257

If the on-p-change callback is fired, then it will trigger a re-render of the parent which will update the props so this setState seems to be unnecessary.

Am I missing something here?