furrer-lab / abn

Bayesian network analysis in R
https://r-bayesian-networks.org/
GNU General Public License v3.0
1 stars 0 forks source link

reset user's option par() or setwd() #32

Closed matteodelucchi closed 2 months ago

matteodelucchi commented 2 months ago

Please make sure that you do not change the user's options, par or working directory. If you really have to do so within functions, please ensure with an immediate call of on.exit() that the settings are reset when the function is exited. e.g.: ... oldpar <- par(no.readonly = TRUE) # code line i on.exit(par(oldpar)) # code line i + 1 ... par(mfrow=c(1,2)) # somewhere after ...

... old <- options() # code line i on.exit(options(old)) # code line i+1 ... options(...) # somewhere after ... e.g.: -> R/abn-methods.R; R/simulateabn.R If you're not familiar with the function, please check ?on.exit. This function makes it possible to restore options before exiting a function even if the function breaks. Therefore it needs to be called immediately after the option change within a function.

Please always make sure to reset to user's options(), working directory or par() after you changed it in examples and vignettes and demos. -> inst/doc/paper.R e.g.: old <- options(digits = 3) ... options(old)

Please fix and resubmit.

matteodelucchi commented 2 months ago

Closing with #14