furrer-lab / abn

Bayesian network analysis in R
https://r-bayesian-networks.org/
GNU General Public License v3.0
1 stars 0 forks source link

start to publish releases #35

Closed j-i-l closed 2 months ago

j-i-l commented 2 months ago

This adds an additional workflow that is triggered on a successful run of the CRAN-like checks and only if `github.ref_type == 'tag', i.e. when a new tag is pushed.

It builds the package (just like the Quick build and test actions does and publishes a new release containing the resulting *.tar.gz.

j-i-l commented 2 months ago

hm, actually, we do not need to condition on the success of the CRAN-like checks as they run on push to main and we have decided to tag manually on main for new releases. Following this procedure any tagged commit on main will already have passed the CRAN-like checks (or at least they were run for this commit, they might also have failed).

If we want to be super strict we can add on > push > tags to the CRAN-like checks and keep the condition on success for of these tests on the Publish Release. In doing so we:

I'm going for this version for now, we can always relax later

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.28%. Comparing base (efd8daf) to head (2803da2). Report is 1 commits behind head on main.

:exclamation: Current head 2803da2 differs from pull request most recent head fae2462. Consider uploading reports for the commit fae2462 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ======================================= Coverage 66.28% 66.28% ======================================= Files 53 53 Lines 10393 10393 ======================================= Hits 6889 6889 Misses 3504 3504 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

j-i-l commented 2 months ago

hmm... Publish Release did not run...

j-i-l commented 2 months ago

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

source

that is likely why.

Will push this to main and make adaptations in a patch