Closed furry13 closed 8 months ago
BTW let me know if/when you think it's ready to be merged - I'll do it and submit -01 to the Datatracker.
I think it's 99% there, I need to suggest text for one more line that outdated I think with the edits since, but I'll have that posted in the next 12 hours, I promise. Otherwise, it LGTM. Thanks for taking all my chaotic feedback!
Also, do you want me to do a separate PR for grammatical/spelling polish tomorrow after you merge, or is that too much work for the -01? Your call.
I think it's 99% there, I need to suggest text for one more line that outdated I think with the edits since, but I'll have that posted in the next 12 hours, I promise. Otherwise, it LGTM. Thanks for taking all my chaotic feedback!
Thanks for reviewing!
Also, do you want me to do a separate PR for grammatical/spelling polish tomorrow after you merge, or is that too much work for the -01? Your call.
Pls send me a PR for fixing my "Runglish" ;) Thanks!
Ok, so either you fixed whatever I saw in December that I wanted to revisit, or I made it up because after a thorough re-read, I'm not finding the inconsistency I thought I saw earlier. Let's merge!
I'll do a final edit pass after you merge so I can fork off the main branch.
Ok, so either you fixed whatever I saw in December that I wanted to revisit, or I made it up because after a thorough re-read, I'm not finding the inconsistency I thought I saw earlier. Let's merge!
Oh I know what you are talking about...It was unfinished sentence, wasn't it? - I did fix it - I thought I responded with a comment but it looks like I didn't ;( Sorry for the confusion.
I'll do a final edit pass after you merge so I can fork off the main branch.
Awesome, thank you!
.... and some other changes