Address Ondrei's and Lorenzo's comments

furry13 / v6ops-464xlat-enable

1 stars 1 forks source link

Address Ondrei's and Lorenzo's comments #3

Closed furry13 closed 8 months ago

furry13 commented 9 months ago

"Start CLAT" section:
- when to start
IPv6 Address section:
- it should be a separate address
- the address shall be checksum-neutral and random
- DAD shall be used
IPv4 address section:
- clarifying wired/wireless terminology
- require 192.0.0.0/29 usage for the latter
- one address per CLAT

.... and some other changes

furry13 commented 8 months ago

BTW let me know if/when you think it's ready to be merged - I'll do it and submit -01 to the Datatracker.

mstojens commented 8 months ago

I think it's 99% there, I need to suggest text for one more line that outdated I think with the edits since, but I'll have that posted in the next 12 hours, I promise. Otherwise, it LGTM. Thanks for taking all my chaotic feedback!

Also, do you want me to do a separate PR for grammatical/spelling polish tomorrow after you merge, or is that too much work for the -01? Your call.

furry13 commented 8 months ago

I think it's 99% there, I need to suggest text for one more line that outdated I think with the edits since, but I'll have that posted in the next 12 hours, I promise. Otherwise, it LGTM. Thanks for taking all my chaotic feedback!

Thanks for reviewing!

Also, do you want me to do a separate PR for grammatical/spelling polish tomorrow after you merge, or is that too much work for the -01? Your call.

Pls send me a PR for fixing my "Runglish" ;) Thanks!

mstojens commented 8 months ago

Ok, so either you fixed whatever I saw in December that I wanted to revisit, or I made it up because after a thorough re-read, I'm not finding the inconsistency I thought I saw earlier. Let's merge!

I'll do a final edit pass after you merge so I can fork off the main branch.

furry13 commented 8 months ago

Ok, so either you fixed whatever I saw in December that I wanted to revisit, or I made it up because after a thorough re-read, I'm not finding the inconsistency I thought I saw earlier. Let's merge!

Oh I know what you are talking about...It was unfinished sentence, wasn't it? - I did fix it - I thought I responded with a comment but it looks like I didn't ;( Sorry for the confusion.

I'll do a final edit pass after you merge so I can fork off the main branch.

Awesome, thank you!