search

furthemore / APIS

Event Management System for Fan Conventions
http://www.furthemore.org/
GNU General Public License v3.0
11 stars 9 forks source link

Makefile step in README.md depends on tokens not available to the general public #319

Open anadon opened 6 months ago

anadon commented 6 months ago 
anadon@botamon:~/Documents/code/APIS$ sudo make build-base-docker-image
docker build \
    --file DockerfileBase \
    --tag ghcr.io/furthemore/apis:apis-base-f7f7012 \
    .
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon    165MB
Step 1/9 : FROM tiangolo/uwsgi-nginx:python3.10
 ---> 08696126c2fc
Step 2/9 : COPY ./requirements.txt /app
 ---> Using cache
 ---> 955c2963eb71
Step 3/9 : WORKDIR /app
 ---> Using cache
 ---> 51145959cfa6
Step 4/9 : RUN apt-get update && apt-get -y install python3-psycopg2 ca-certificates xfonts-75dpi xfonts-base
 ---> Using cache
 ---> 0c084b158537
Step 5/9 : RUN wget -nv https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6-1/wkhtmltox_0.12.6-1.buster_amd64.deb
 ---> Using cache
 ---> d2b55e6d3ae3
Step 6/9 : RUN dpkg -i wkhtmltox_0.12.6-1.buster_amd64.deb
 ---> Using cache
 ---> d8bf7f5fce9e
Step 7/9 : RUN apt-get -y -f install
 ---> Using cache
 ---> 3e84c58d2933
Step 8/9 : RUN pip install --upgrade pip
 ---> Using cache
 ---> b7cf78a6c6de
Step 9/9 : RUN pip install -r requirements.txt
 ---> Using cache
 ---> 99a9f75fc922
Successfully built 99a9f75fc922
Successfully tagged ghcr.io/furthemore/apis:apis-base-f7f7012
docker push ghcr.io/furthemore/apis:apis-base-f7f7012
The push refers to repository [ghcr.io/furthemore/apis]
5884222db80c: Preparing 
3bef94f4a0dd: Preparing 
2ac0383fec2b: Preparing 
db33db087b33: Preparing 
4988fabdbf1a: Preparing 
ecb96af9db48: Waiting 
03b6c59eef96: Waiting 
5f70bf18a086: Waiting 
3e8d5fb7b985: Waiting 
4b7bde732aa4: Waiting 
4dceb6577372: Waiting 
68bca5d047be: Waiting 
d45eaa7e927d: Waiting 
ee6b7cdb368c: Waiting 
b9cf9d82e209: Waiting 
cd4005c7c616: Waiting 
e8c99490dec8: Waiting 
188de2956bc1: Waiting 
537a5ab787c7: Waiting 
d6df9f63e289: Waiting 
c0882faee856: Waiting 
208dc905717c: Waiting 
d7bab048be12: Waiting 
8fbfff347a19: Waiting 
ed453e999965: Waiting 
90ee0673253b: Waiting 
3f5b63bda090: Waiting 
8074245e25ed: Waiting 
71e1aa306a5a: Waiting 
69f16cc74eb0: Waiting 
82677505c894: Waiting 
unauthorized: unauthenticated: User cannot be authenticated with the token provided.
make: [Makefile:36: build-base-docker-image] Error 1 (ignored)
sed -i 's/apis-base-.*$/apis-base-f7f7012/' Dockerfile
anadon commented 6 months ago

Looks like a possibly unnecessary push for the general README. I think the instructions need to be altered.

rechner commented 6 months ago

Hi @anadon,

Those commands are used by committers to push and maintain images to our docker image repo, and documented for the sake of devs within our organization. You can safely ignore that push error for local docker development if you want to use the makefile instructions, or run the docker build and tag steps without push directly, or fork and change the image repo URL for use on your own infrastructure.

I'll happily accept a PR to modify the README for any notes you might have trying to set this up for your own uses, to help others trying it out.

Thanks.

anadon commented 5 months ago

Add notes about: