further-external / Apollo-Documentation-Connected-Vehicle

An Apollo generated Event Driven Data Layer
0 stars 0 forks source link

User Signed In #18

Open jeffkush-sdi opened 1 year ago

jeffkush-sdi commented 1 year ago

User Signed In

QA Jan 26: Comment

jeffkush-sdi commented 9 months ago

@Shocopop Hey Anton, so was trying to trigger this event during my QA and was unable to find an applicable link/page(?). Can you send me quick steps or URI that can facilitate QA on this event? Essentially this request applies to 'all' user sign-in related events. thx in advance

Shocopop commented 9 months ago

@jeffkush-sdi This is fixed, user sign-in is now being fired on otp validation

jeffkush-sdi commented 9 months ago

@Shocopop So maybe I need to start from an alternate URI...IDK, but how I start is from here https://cwp.sit.siriusxmguardian.com/manage?u=64c17925-1ca4-4593-a2a5-261d6d975b08&v=bef0957f-673b-48bf-b1d6-53ae157ff65a&lang=en-US > YOP get code > Enter code SXM

I dont see a sign in link anywhere(?) but I think someone on team mentioned [FWW] may not have a user yet(?) Not entirely sure of context here, but I vaguely recall, Is there a alternate URL you can pass along...I know you coded something. TY

Image

Shocopop commented 9 months ago

@jeffkush-sdi This event now fires after the OTP step

jeffkush-sdi commented 9 months ago

@Shocopop

QA .SIT

ISSUE (minor) Now seeing this event fire; TY. The minor issue I see is the event schema is missing the hashedEmail parameter. This may not be possible, or entirely necessary. If we can do it...I would do it; but will review with @msawlorSDI and confirm the need.

Image

Image

Shocopop commented 9 months ago

@jeffkush-sdi Yep, you are right, hashedEmail was missing in the schema that I have created in the code (for this event), thus it's not present, the change is very simple to do, two lines of code. I will make the PR, it will be merged either on Monday or tomorrow (if someone can approve my PR tomorrow). Although that change wouldn't be in staging for a while now (but it shouldn't be a blocking issue I guess)

jeffkush-sdi commented 9 months ago

@Shocopop see hashed email now,TY