search

further-external / client-ckf-data-layer-spec

0 stars 2 forks source link

search #37

Open cade-egbert opened 1 year ago

cade-egbert commented 1 year ago

I think we should update and add for if you click on location and the location performs the search

jsmithckfi commented 1 year ago

@cade-egbert test

adeSDI commented 1 year ago

@jsmithckfi Hey Jason, what are you thoughts on: updating and firing search event if the location is typed in? See Cade's comment above.

jsmithckfi commented 1 year ago

@adeSDI @cade-egbert, I believe this has been updated in the new search and sort features getting ready to deploy. I've tested in my dev, by searching 45503 and clicking the result.

Screen Shot 2023-01-09 at 3 18 03 PM
cade-egbert commented 1 year ago

@jsmithckfi It seems like now we are only seeing 'search' fire when I select whatever location I searched for. Rather than when I type in the data. So now search and view_search_results fire at the same time. Would you like to only have one? Or does 'search' need to be updated for when a user types in a location? @adeSDI

jsmithckfi commented 1 year ago

@cade-egbert @adeSDI

I'm not sure. We can talk through on the Sprint today if that works.