further-external / loews-dl-spec-ga4

An Apollo generated Event Driven Data Layer
0 stars 1 forks source link

Room Listing Displayed #30

Open braxton-butcher opened 1 year ago

braxton-butcher commented 1 year ago

https://github.com/searchdiscovery/loews-dl-spec-ga4/blob/main/Data%20Layer%20Events/Room%20Listing%20Displayed.md

The new Google dataLayer events should fire in all scenarios where the corresponding appEventData data layer event fires.

Please reference the Data Layers Event Mapping document to see the relationship between the two data layers events.

Reference the Data Layers Attribute Mapping document to see how the specific attributes of the old appEventData data layer corresponds to the attributes of the new dataLayer data layer.

Reference the Location ID Mapping document to see how to populate ecommerce.items.item_id and event_data.location_id in the new data layer. Both of these should contain the corresponding hotel code as found in the aforementioned document.

You may also reference the “Attached Notes” section of the event’s specs to determine where and when to fire.

braxton-butcher commented 1 year ago

@dbokadiya

Event fires in the correct scenario

Image

Improvements needed: item_list_name: Should be the name of the Item List. The name of the hotel should suffice

item_id: Should be the numeric id of the hotel - see this document for mapping of hotel names to IDs: https://docs.google.com/spreadsheets/d/1PDhNOzXI9E7jZ9obejV4owtW3Wtwq66_IaN-CBoHbRs/edit#gid=1543857253

market_code: If this value is missing, it should be an empty string ("") instead of null

room_rate_code: If the value is missing, it should be an empty string ("") instead of null

dbokadiya commented 1 year ago

@braxton-butcher What should be there for item_list_name can you please give me any example.

braxton-butcher commented 1 year ago

@dbokadiya The name of the hotel should be fine for item_list_name. In the example from my previous comment it would be "Loews Hotel Atlanta"

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

Event fires in the correct scenario and values are accurate:

Image

Moved to "Done"

braxton-butcher commented 1 year ago

@dbokadiya

Reopening this ticket, one minor improvement is needed. item_id should populate with type string rather than int. In the example in the earlier screenshot it would be "70561" rather than 70561. This will be consistent in the items array across all events. Apologies for not catching this earlier!

dbokadiya commented 1 year ago

@braxton-butcher Change is done kindly review again.

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

Event fires in the correct scenario:

Image

Marked as "Done"