further-external / loews-dl-spec-ga4

An Apollo generated Event Driven Data Layer
0 stars 1 forks source link

User Detected #31

Open braxton-butcher opened 1 year ago

braxton-butcher commented 1 year ago

https://github.com/searchdiscovery/loews-dl-spec-ga4/blob/main/Data%20Layer%20Events/User%20Detected.md

The new Google dataLayer events should fire in all scenarios where the corresponding appEventData data layer event fires.

Please reference the Data Layers Event Mapping document to see the relationship between the two data layers events.

Reference the Data Layers Attribute Mapping document to see how the specific attributes of the old appEventData data layer corresponds to the attributes of the new dataLayer data layer.

Reference the Location ID Mapping document to see how to populate ecommerce.items.item_id and event_data.location_id in the new data layer. Both of these should contain the corresponding hotel code as found in the aforementioned document.

You may also reference the “Attached Notes” section of the event’s specs to determine where and when to fire.

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

Moving back this to "In Progress" this event needs to fire site wide. Credentials do not work on main site:

Image

Event fires in the correct scenario:

Image Image

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

There is an update on this event script documentation. It needs to fire once per session.

Basically we don't need to clear the page_data anymore:

window.dataLayer = window.dataLayer || [];
dataLayer.push({
  "event": "detect_user",
  "detailed_event": "User Detected",
    "user_data": {
        "user_login_state": "<user_login_state>"
    }
});
brendenconcannon commented 1 year ago

@braxton-butcher - This login is Auth0 URL as well. Wondering if they need to implement the User events.

JH-SDI commented 1 year ago

@estum1 @brendenconcannon @dbokadiya

This event is not firing on the main site:

Image

For the booking engine, the event is firing once per session as requested but it requires an improvement regarding to the sequence, it needs to fire like this:

We will want to fire the events in this sequence. Page Load Started > User Detected > Page Load Completed:

Image

Moved to "Prod Improve"

JH-SDI commented 1 year ago

@estum1 @brendenconcannon @dbokadiya

This event is not firing on the main site and still do not follow the sequence on the BE.

Moved to "Prod Improvement"

brendenconcannon commented 1 year ago

@JH-SDI - - devs have completed updates - can you please test?

JH-SDI commented 1 year ago

@brendenconcannon

Event is firing but not on the specific order:

We will want to fire the events in this sequence. Page Load Started > User Detected > Page Load Completed:

Image

brendenconcannon commented 1 year ago

@JH-SDI - - updates have been deployed for this event. Can you please test?

JH-SDI commented 1 year ago

@brendenconcannon

Event is firing in the correct scenario only for the Booking engine:

Image Image Image

On the main site is not firing anymore.

brendenconcannon commented 1 year ago

@braxton-butcher - Updates have been made. Can you please test this event again?

JH-SDI commented 1 year ago

@brendenconcannon @estum1

Event is not firing on the main site.

Event should fire in this sequence. Page Load Started > User Detected > Page Load Completed

As you can see, user_detected is not firing

Image

cade-egbert commented 1 year ago

Seems to work in prod, but as Jaime said not on live site image

brendenconcannon commented 1 year ago

@cade-egbert @JH-SDI - Can you please retest this event today?

JH-SDI commented 1 year ago

@brendenconcannon

Event is working as expected:

Image

Moved to complete