further-external / loews-dl-spec-ga4

An Apollo generated Event Driven Data Layer
0 stars 1 forks source link

User Signed Out #35

Open braxton-butcher opened 1 year ago

braxton-butcher commented 1 year ago

https://github.com/searchdiscovery/loews-dl-spec-ga4/blob/main/Data%20Layer%20Events/User%20Signed%20Out.md

The new Google dataLayer events should fire in all scenarios where the corresponding appEventData data layer event fires.

Please reference the Data Layers Event Mapping document to see the relationship between the two data layers events.

Reference the Data Layers Attribute Mapping document to see how the specific attributes of the old appEventData data layer corresponds to the attributes of the new dataLayer data layer.

Reference the Location ID Mapping document to see how to populate ecommerce.items.item_id and event_data.location_id in the new data layer. Both of these should contain the corresponding hotel code as found in the aforementioned document.

You may also reference the “Attached Notes” section of the event’s specs to determine where and when to fire.

brendenconcannon commented 1 year ago

@braxton-butcher - Any feedback for this event?

JH-SDI commented 1 year ago

@brendenconcannon

Moved back this one to "In Progress" for these reasons:

dbokadiya commented 1 year ago

@JH-SDI Please check once when that login issue will resolved.

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

Moved back this one to "to do" for these reasons:

User sign in event has an issue that kicks out a signed user immediately, so there is no chance for the user for actual signing out. When the user gets kicked out, no sign out event is fired this event needs to fire site wide

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

Tested this event with the following credentials:

alex.saveljev@nextguest.com LoewsStaging1

Event not firing.

Moved back to "to do"

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon @estum1

Event do not fire on main site and booking engine.

Moved to "prod Improvement"

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon @estum1

Event do not fire on main site and booking engine.

Moved to "prod Improvement"

dbokadiya commented 1 year ago

@JH-SDI

Issue resolved in booking engine kindly review in BE.

brendenconcannon commented 1 year ago

@JH-SDI - devs have completed updates - can you please test?

JH-SDI commented 1 year ago

@brendenconcannon

Event is firing on main site but is still not firing on the BE

brendenconcannon commented 1 year ago

@JH-SDI - updates have been deployed for this event. Can you please test?

JH-SDI commented 1 year ago

@brendenconcannon

Error persist on the BE:

Image

brendenconcannon commented 1 year ago

@JH-SDI - You are getting this authentication error when logging out? We have tested several credentials and have not been able to reproduce this authentication error. Are you able to try other credentials? Not sure what next steps for this one would be.

JH-SDI commented 1 year ago

@brendenconcannon

Event is firing as expected:

Image

Moved to complete