furushchev / respeaker_ros

A ROS Package for Respeaker Mic Array
Apache License 2.0
71 stars 60 forks source link

Refactor code into a Python module #19

Open nickswalker opened 4 years ago

nickswalker commented 4 years ago

This PR will let people import the RespeakerInterface and RespeakerAudio classes in code they write inside other packages. This is accomplished by using catkin's support for installing a package's Python modules.

furushchev commented 4 years ago

@nickswalker Thank you for sending PR! I still don't try your patch, but isn't this PR deleting executable from the package, which means the node is unable to be executed from launch file or with rosrun call?