fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
230 stars 163 forks source link

Commented the self.initialize #709

Closed nasimanousheh closed 1 year ago

nasimanousheh commented 1 year ago

When I upgraded FURY in Furious Atoms (https://furiousatoms.com), I noticed a second window appears and the loaded file is shown in the second window as you see here:

demo

The issue is in ShowManager. I commented the lines 395 and 396 in window.py and now it works perfectly:

demo2

codecov[bot] commented 1 year ago

Codecov Report

Merging #709 (befd69e) into master (8e1cc27) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   50.19%   50.20%   +0.01%     
==========================================
  Files         120      120              
  Lines       28019    28015       -4     
  Branches     2987     2985       -2     
==========================================
+ Hits        14063    14064       +1     
+ Misses      13489    13486       -3     
+ Partials      467      465       -2     
Impacted Files Coverage Δ
fury/window.py 0.00% <ø> (ø)
fury/fury/stream/tools.py 91.15% <0.00%> (+0.21%) :arrow_up:
fury/fury/window.py 74.48% <0.00%> (+0.33%) :arrow_up:
Garyfallidis commented 1 year ago

Okay, I think people were not careful with where they added self.initialize in the ShowManager. @nasimanousheh can you also show the gif of the changes. Initialize was always on the ShowManager methods but not in the constructor. Otherwise every other GUI system will be incompatible with FURY.

Garyfallidis commented 1 year ago

When I see gif of changes. I actually mean the git diff between current version and a previous version before that initialization was added in the constructor.

nasimanousheh commented 1 year ago

Here is the difference:

demo5

Garyfallidis commented 1 year ago

Addressed in #744