Principled update

[guaje]

This PR includes the changes to the Principled BRDF used for the Horizon manuscript.

[codecov[bot]]

Codecov Report

Merging #710 (9dfe873) into master (8710a65) will decrease coverage by 0.29%. The diff coverage is n/a.

:exclamation: Current head 9dfe873 differs from pull request most recent head 0f46827. Consider uploading reports for the commit 0f46827 to get more accurate results

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
- Coverage   50.47%   50.19%   -0.29%     
==========================================
  Files         126      120       -6     
  Lines       28299    28019     -280     
  Branches     3034     2987      -47     
==========================================
- Hits        14284    14063     -221     
+ Misses      13536    13489      -47     
+ Partials      479      467      -12     

Impacted Files	Coverage Δ
fury/fury/tests/test_window.py	71.54% <0.00%> (-10.56%)	:arrow_down:
fury/fury/animation/timeline.py	66.08% <0.00%> (-10.43%)	:arrow_down:
fury/fury/shaders/base.py	84.84% <0.00%> (-8.09%)	:arrow_down:
fury/fury/window.py	74.14% <0.00%> (-5.63%)	:arrow_down:
fury/fury/animation/tests/test_timeline.py	98.61% <0.00%> (-1.39%)	:arrow_down:
fury/fury/actor.py	88.18% <0.00%> (-0.65%)	:arrow_down:
fury/fury/ui/elements.py	89.66% <0.00%> (-0.07%)	:arrow_down:
fury/gltf.py	0.00% <0.00%> (ø)
fury/window.py	0.00% <0.00%> (ø)
fury/fury/gltf.py	80.33% <0.00%> (ø)
... and 9 more

[skoudoro]

This PR start to be big and hard to review. is it possible to split it in smaller PR?

Also, when do you think we could have a first initial version ? Thank you for the feedback

[guaje]

This PR start to be big and hard to review. is it possible to split it in smaller PR?

Definitely! I'll remove many of the python files, so in the end the PR will consist of a few modifications of the material.py and test_material.py files and the addition of all the PBR/principled functions.

Also, when do you think we could have a first initial version ? Thank you for the feedback

I'm trying to fix something with the geometry shadowing functions and then it'll be ready.

[Garyfallidis]

@guaje we need to rebase this.

[Garyfallidis]

Great work @guaje !