search

fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
230 stars 163 forks source link

[WIP] Implementation of PBR in glTF #715

Open xtanion opened 1 year ago

xtanion commented 1 year ago

This PR needs a lot of cleaning and still in progress. As of now this PR adds ORM, Normal & Emissive materials. Most of the glTF models has been modified to use the ORM material, however few of them still use MetallicRoughness and AmbientOcclusion materials separately (for e.g. DamagedHelmet & Avocado). Few model may have RoughnessMetallic instead of MetallicRoughness which changes switches the channels (For e.g. the Avocado model), as mentioned in this comment. This PR currently does not support the RoughnessMetallic.

Preview with the DamagedHelmet (has all three of materials) model: image

Sample of the Avocado model (without switching the channels in RoughnessMetallic to MetallicRoughness) ( Left) After switching channels (Right):

Garyfallidis commented 1 year ago

Very impressive !!! Emissive seems working very well.

Garyfallidis commented 1 year ago

Why the colors are so dark on the helmet? The correct rendering should look like this...

image

From the description above I am not sure where the issue is.

Garyfallidis commented 1 year ago

Above IBL is on. This is how it should look without IBL.

image

Garyfallidis commented 1 year ago

@xtanion this PR needs rebasing. We should resume the glft/pbr meeting too @guaje

Garyfallidis commented 1 year ago

@xtanion please resolve conflicts and let's move to the final steps of Gltf support. @guaje let's meet asap!

xtanion commented 1 year ago

Sorry for the late reply @Garyfallidis, my school examinations were going on. I'll fix this ASAP.

Garyfallidis commented 1 year ago

Ping @xtanion Let us know if you need a meeting to finalize this.

Garyfallidis commented 1 year ago

@xtanion please provide feedback asap.

xtanion commented 1 year ago

Sorry for the late response, I was traveling this entire week. I'll be working on this from Friday.

skoudoro commented 1 year ago

Sorry for the late response, I was traveling this entire week. I'll be working on this from Friday.

Great! Do you have any progress on this? if yes, can you push it?

thank you @xtanion.

ps: Also, it would be great if you could attend the fury open meeting this Thursday (March 30)

skoudoro commented 1 year ago

ping @xtanion

Garyfallidis commented 1 year ago

There are still some conflicts. Can you also list the remaining steps needed for this PR? @xtanion ?

Garyfallidis commented 1 year ago

@xtanion a reminder to move forward with this PR.